Skip to content

Update buildah to v1.11.0#3948

Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom
openSUSE:buildah-update
Sep 5, 2019
Merged

Update buildah to v1.11.0#3948
openshift-merge-robot merged 1 commit intocontainers:masterfrom
openSUSE:buildah-update

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 5, 2019

Vendor in the latest changes for buildah to apply the implemented
features here as well.

@saschagrunert
Update buildah to v1.11.0
f66a206 
Vendor in the latest changes for buildah to apply the implemented
features here as well.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2019
@mheon
Copy link
Member

mheon commented Sep 5, 2019

LGTM pending green tests

@mheon
Copy link
Member

mheon commented Sep 5, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Sep 5, 2019

@saschagrunert Can I be a complete PITA and ask you to revendor Buildah for this PR? I messed up and we'd some tag mess-ups with Buildah for v1.11.0 that were just straightened out, I think after you did this vendoring.

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Sep 5, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2019
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 5, 2019 •
edited
Loading

@saschagrunert Can I be a complete PITA and ask you to revendor Buildah for this PR? I messed up and we'd some tag mess-ups with Buildah for v1.11.0 that were just straightened out, I think after you did this vendoring.

Hm, I get no changes If I run make vendor, I wiped the go/pkg/mod but this also implies no vendor changes.

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Sep 5, 2019

@saschagrunert thanks for checking. I'd just had the brilliant idea, one that I should have had earlier, to check the file changes from Buildah in here. You don't have the changes that were added after 1.11.0 was created, only the ones that I'd expect for v1.11.0. This looks to be correct, I'll cancel the hold. Thanks again for looking and apologies for the churn.

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Sep 5, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2019
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Sep 5, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit cef5bec into containers:master Sep 5, 2019
This was referenced Sep 5, 2019
Closed
Closed
@saschagrunert saschagrunert deleted the buildah-update branch September 5, 2019 18:34
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@rhatdan rhatdan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saschagrunert @mheon @openshift-ci-robot @TomSweeneyRedHat @rhatdan @openshift-merge-robot